GOATS-945: Add ToO observation submission and hooks in GPP application. #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor form field IDs and names for consistency across the application.
There was a problem hiding this comment.
Pull Request Overview
Refactors form field IDs and names for consistency across the GPP application and adds ToO (Target of Opportunity) observation submission functionality with enhanced form data handling.
- Standardized form element IDs and names to follow consistent naming conventions
- Added ToO observation creation and submission capability with error handling and toast notifications
- Enhanced form data extraction methods and improved input field configurations
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| source_profile_editor.js | Updated form field IDs to use more descriptive names like sedProfileTypeSelect and sedTypeSelect |
| program_observations_panel.js | Added JSDoc documentation for select toggle methods |
| observation_form.js | Enhanced form controls with consistent naming, decimal support for number inputs, and new getData() method |
| gpp.js | Added ToO observation creation functionality with proper error handling and toast notifications |
| fields.js | Refactored select options to use value/labelText objects instead of plain strings |
| exposure_mode_editor.js | Added name attributes to form elements for consistency |
| elevation_range_editor.js | Added name attributes to form elements for consistency |
| brightnesses_editor.js | Simplified ID generation and updated select creation method signature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changesusing the PR number.